Migrate from deprecated v1 Endpoints to discovery.k8s.io/v1 EndpointSlice#9032
Merged
Merged
Conversation
knative-prow
Bot
added
do-not-merge/work-in-progress
knative-prow
Bot
added
the
approved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9032 +/- ##
==========================================
- Coverage 51.07% 50.95% -0.12%
==========================================
Files 409 411 +2
Lines 21999 22069 +70
==========================================
+ Hits 11235 11246 +11
- Misses 9901 9958 +57
- Partials 863 865 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lice The Kubernetes v1 Endpoints API is deprecated in v1.33+. This migrates the Broker, InMemoryChannel, and EventTransform reconcilers to use EndpointSlice with label-based listing instead of name-based Endpoints lookups, and updates RBAC roles, test helpers, and all test files.
creydr
force-pushed
the
migrate-to-endpoint-slice
branch
from
66960b5 to
5afe170
Compare
creydr
changed the title
knative-prow
Bot
removed
the
do-not-merge/work-in-progress
Member
Author
|
Downstream rabbitmq tests are failing, because it needs to migrate to the "new" eventing API |
Member
Author
Member
Author
dsimansk
reviewed
May 18, 2026
| verbs: | ||
| - "get" | ||
| - "list" | ||
| - "watch" |
Contributor
There was a problem hiding this comment.
I assume it's enough ops for current functionality, correct?
Contributor
|
/approve Feel free to proceed if there're no more outstanding reviews. |
knative-prow
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/unhold |
knative-prow
Bot
removed
the
do-not-merge/hold
knative-prow Bot
pushed a commit
to knative-extensions/eventing-rabbitmq
that referenced
this pull request
May 20, 2026
* upgrade to latest dependencies bumping knative.dev/eventing 43e651f...504f7e0: > 504f7e0 Fix outdated documentation: broken links, wrong paths, stale claims (# 9087) > 96ca1b2 Migrate from deprecated v1 Endpoints to discovery.k8s.io/v1 EndpointSlice (# 9032) > fdfff0b build(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 from 1.95.0 to 1.97.3 (# 9051) Signed-off-by: Knative Automation <automation@knative.team> * Migrate from deprecated Endpoints to EndpointSlice The upstream knative/eventing dependency (knative/eventing#9032) migrated from the deprecated v1 Endpoints API to discovery.k8s.io/v1 EndpointSlice. This adapts the RabbitMQ broker reconciler to use the new API. Changes: - Replace endpointsLister with endpointSliceLister using label-based listing (discoveryv1.LabelServiceName) - Update PropagateIngressAvailability to accept []*discoveryv1.EndpointSlice and use duck.EndpointSlicesAreAvailable - Use kube SharedInformerFactory for EndpointSlice informer since knative/pkg does not yet provide a dedicated injection wrapper - Update all test fixtures from Endpoints to EndpointSlice * run hack/update-codegen.sh * Add RBAC permissions for endpointslices The broker controller needs get/list/watch on endpointslices in the discovery.k8s.io API group to check ingress availability after migrating from the deprecated Endpoints API. * Explicitly start EndpointSlice informer Unlike standard injection informers, the EndpointSlice informer obtained from the SharedInformerFactory is not registered with the injection framework and thus not automatically started. Start it explicitly to ensure its cache is populated. --------- Signed-off-by: Knative Automation <automation@knative.team> Co-authored-by: Knative Automation <automation@knative.team>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kubernetes v1 Endpoints API is deprecated in v1.33+.
Proposed Changes